Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lint): lint ts types using CI #2956

Merged
merged 6 commits into from
Dec 19, 2023
Merged

feat(lint): lint ts types using CI #2956

merged 6 commits into from
Dec 19, 2023

Conversation

mvorisek
Copy link
Contributor

@mvorisek mvorisek commented Dec 4, 2023

This PR improves #2822, the Typescript is now tested if compiles and linted againts our coding style.

@mvorisek mvorisek changed the title Link TypeScript using CI Link TS types using CI Dec 4, 2023
@mvorisek mvorisek changed the title Link TS types using CI Lint TS types using CI Dec 5, 2023
@mvorisek mvorisek force-pushed the ts_lint branch 4 times, most recently from b1defd3 to e4b19e3 Compare December 19, 2023 13:02
@mvorisek mvorisek marked this pull request as ready for review December 19, 2023 13:04
@mvorisek mvorisek mentioned this pull request Dec 19, 2023
Closed
lubber-de
lubber-de approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i only changed the "empty" to "notEmpty" rule inside the tests.ts while we are at it ;)

@lubber-de lubber-de changed the title Lint TS types using CI feat(lint): lint ts types using CI Dec 19, 2023
@lubber-de lubber-de merged commit 4effaa3 into fomantic:develop Dec 19, 2023
9 checks passed
@lubber-de lubber-de added this to the 2.9.4 milestone Dec 19, 2023
@lubber-de lubber-de added type/ci Anything related to CI/CD type/types Anything related to types type/lint eslint / stylelint related changes only labels Dec 19, 2023
@mvorisek mvorisek deleted the ts_lint branch December 19, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@ko2in ko2in Awaiting requested review from ko2in

@prudho prudho Awaiting requested review from prudho

@y0hami y0hami Awaiting requested review from y0hami

Assignees
No one assigned
Labels
type/ci Anything related to CI/CD type/lint eslint / stylelint related changes only type/types Anything related to types
Projects
None yet
Milestone
2.9.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mvorisek @lubber-de